Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Nw4- Bimbola Lasisi- JavaScripts-Core-1-Week1 - #118

Closed
blasisi wants to merge 1 commit into
CodeYourFuture:masterfrom
blasisi:JavsScript-Chanllenges
Closed

Nw4- Bimbola Lasisi- JavaScripts-Core-1-Week1#118
blasisi wants to merge 1 commit into
CodeYourFuture:masterfrom
blasisi:JavsScript-Chanllenges

Conversation

@blasisi

@blasisi blasisi commented Jun 23, 2021

Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name:
  • Your City:
  • Your Slack Name:

Homework Details

  • Module:
  • Week:

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

@nax2uk nax2uk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @blasisi 👍🏾👏🏽
Please see my feedback

Comment thread mandatory/4-tax.js
Comment on lines +25 to +29
let taxPercentages = "£" + (price/100);
return formattedPrice;
}
let result2 = addTaxAndFormatCurrency(20) ;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let taxPercentages = "£" + (price/100);
return formattedPrice;
}
let result2 = addTaxAndFormatCurrency(20) ;
const priceWithTax = calculateSalesTax(price);
const formattedPrice = '£' + priceWithTax.toFixed(2);
return formattedPrice;

@github-actions

Copy link
Copy Markdown

Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback.

@github-actions github-actions Bot added the Stale label Aug 22, 2021
@github-actions github-actions Bot closed this Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants