NW5 - Haroon Ali - HTML & CSS - Week 1 - #439
Open
haroon-ali-dev wants to merge 20 commits into
Open
Conversation
|
That is great job Haroon . |
khmdagal
reviewed
Aug 11, 2022
khmdagal
reviewed
Aug 11, 2022
khmdagal
reviewed
Aug 11, 2022
khmdagal
reviewed
Aug 11, 2022
|
|
||
| .hero { | ||
| height: 850px; | ||
| background-image: url('../img/first-background.jpg'); |
There was a problem hiding this comment.
The background image should be half of the screen. You can review the picture named "homepage-desktop.png".
khmdagal
reviewed
Aug 11, 2022
| .nav-section { | ||
| width: 100%; | ||
| } | ||
|
|
There was a problem hiding this comment.
Your nav section should have good contrast in line with the WCAG which means Web Content Accessibility Guidelines.
khmdagal
reviewed
Aug 11, 2022
| } | ||
|
|
||
| /*footer*/ | ||
|
|
There was a problem hiding this comment.
In the footer part there is color contrast issue. and that needs to be worked on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
creating the hero section
What did you find hard?
creating the nav bar
What do you still not understand?
n/a
Any other notes?
n/a