LONDON_9_FarnooshMoayeri-HTML/CSS-WEEK-3 - #452
Conversation
| @@ -1 +1,116 @@ | |||
| /* Add your styling here */ | |||
| body { | |||
There was a problem hiding this comment.
Hi Farnoosh, good try on this PR, but it seems like your page is not responsive, can you work on that?
There was a problem hiding this comment.
I have worded on that, I look forward to hear your suggestions:)
| <body> | ||
| <!-- Add your markup here --> | ||
| </body> | ||
| <header class="header" style="height: 32vh"> |
There was a problem hiding this comment.
It is better to use css to configure style, can you try move this into ccs?
| <li class="nav_item"><a class="nav_link" href="#"> Ordering</a></li> | ||
| <li class="nav_item"><a class="nav_link" href="#">Lessons</a></li> | ||
| <li class="nav_item"><a class="nav_link" href="#">About</a></li> | ||
| </ul> |
There was a problem hiding this comment.
At the moment, these links does not seems to do anything, is it still work in progress?
There was a problem hiding this comment.
I haven't linked them yet. Actually I forgot it :(
| } | ||
|
|
||
| /* hero */ | ||
| .hero { |
There was a problem hiding this comment.
I used it because I thought it was the important section. Was it wrong?
There was a problem hiding this comment.
This term is new to me in this context, thus my question.
I googled and found the answer: https://www.awebco.com/blog/hero-section/
all good
| </p> | ||
| </div> | ||
| <div class="welcome_image"> | ||
| <img src="img/Cake-.jpeg" alt="cake" width="300" height="300" /> |
There was a problem hiding this comment.
Ditto, it is better to use css to configure style, and you probably want to avoid hard coding width and height for it to be responsive
There was a problem hiding this comment.
Hard coding normally means writing special numbers into your code that is hard/impossible to change without changing code
There was a problem hiding this comment.
Thank you for the information.
| width="200" | ||
| height="100" | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
Ditto for all hard coded width/height
|
Hi @Farnooshmo , is this ready for review? if so, can you deploy to netlify so that I can have a look? If not ready yet that's ok, just let me know when it is |
|
Hi @qingwei91, Tomorrow I will deploy it and let you know 🙏 |
|
Hi @qingwei91 , here is the link to the cake project: |
|
Great improvement 👍 There's a lot of space on the right, and its not aligned properly, can you think of a way to solve this?
|
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?Alignment/grid
What do you still not understand?Alignment/ grid
Any other notes?
View rendered .github/pull_request_template.md