This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London 9 - Natalie Zablotska- HTML & CSS - Week 3 - #451
Open
nataliiazab wants to merge 17 commits into
Open
Conversation
Author
|
Hi Sami,
Thanks!!! |
Author
Hamisakim
reviewed
Nov 14, 2022
There was a problem hiding this comment.
Great Work Natalia!
Look into restructuring the navbar. We want our code to be as readable as possible. Let me know if this isn't clear enough :)
- Use
gapto the flex parent instead of adding a margin to the children. - use fixed values for the images. Experiment using min-width and max-width etc.
width: 20rem;
height: 20rem;
| } | ||
|
|
||
| .nav-item { | ||
| margin-left: 5rem; |
There was a problem hiding this comment.
this will always give the items a margin-left, even on smaller screens, causing them to overlap
|
|
||
| .navbar { | ||
| display: flex; | ||
| justify-content: flex-end; |
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| flex-direction: row; |
| </section> | ||
| <div class="body"> | ||
| <header class="header"> | ||
| <nav class="navbar"> |
There was a problem hiding this comment.
Consider how you've built the navbar here -- it's a lot of nesting, making it harder to debug and style.
something like the below
<nav class="navbar">
<div class=nav-items>
<a href="proxy.php?url=https%3A%2F%2Fgithub.com%2FCodeYourFuture%2FHTML-CSS-Coursework-Week3%2Fpull%2F451%23" class="nav-link">Home</a>
<a href="proxy.php?url=https%3A%2F%2Fgithub.com%2FCodeYourFuture%2FHTML-CSS-Coursework-Week3%2Fpull%2F451%23" class="nav-link">Cakes</a>
<a href="proxy.php?url=https%3A%2F%2Fgithub.com%2FCodeYourFuture%2FHTML-CSS-Coursework-Week3%2Fpull%2F451%23" class="nav-link">Orderin</a>
<a href="proxy.php?url=https%3A%2F%2Fgithub.com%2FCodeYourFuture%2FHTML-CSS-Coursework-Week3%2Fpull%2F451%23" class="nav-link">Lessons</a>
<a href="proxy.php?url=https%3A%2F%2Fgithub.com%2FCodeYourFuture%2FHTML-CSS-Coursework-Week3%2Fpull%2F451%23" class="nav-link">About</a>
</div>
<div class="hamburger">
<span class="bar"></span>
<span class="bar"></span>
<span class="bar"></span>
</div>
</nav>
Author
|
@Hamisakim thank you very much for all the comments and for reviewing my code! Everything is clear! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repository