NW5-Manchester-Sandra Duarte-HTML/CSS -week-3 - #395
Conversation
Ara225
left a comment
There was a problem hiding this comment.
I really love the look and feel of this, you've obviously taken time with the colors and font, they look really good. The responsive side of things isn't really working that well sadly, but it's good that you made a start, I can see you understand the basics of media queries
| <!--portfolio--> | ||
| <section class="portfolio"> | ||
|
|
||
| <img class="images1" src="/img/pexels-daria-shevtsova.jpg" alt="#"> |
There was a problem hiding this comment.
It would be best to add alt text explaining what the the image is if possible :)
There was a problem hiding this comment.
I really love the look and feel of this, you've obviously taken time with the colors and font, they look really good. The responsive side of things isn't really working that well sadly, but it's good that you made a start, I can see you understand the basics of media queries
Thank a lot for your feedback.
| cursor: pointer; | ||
| } | ||
| .card-social{ | ||
| border: 1px; solid #b1b4b7; |
|
|
||
|
|
||
|
|
||
| /*grid style |
There was a problem hiding this comment.
Best not to leave commented out code in if possible
|
|
||
| /*media queries*/ | ||
|
|
||
| @media ( max-width: 540px) { |
There was a problem hiding this comment.
I actually quite like the way the buttons go on smaller screens, it's not what the design asked for but it's still really nice in it's own way, could have done with a bit more work to add a middle breakpoint and make the smallest breakpoint look like the mobile veiw
| text-align: center; | ||
| } | ||
|
|
||
| .main-paragrafo p{ |
| </ul> | ||
| </nav> | ||
| <!--end header--> | ||
| <!-- top container--> |
There was a problem hiding this comment.
Could have done with a opening main tag here, but your sematic HTML is good otherwise :)
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?