Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Finished Cake project - #148

Closed
Texx45 wants to merge 4 commits into
CodeYourFuture:masterfrom
Texx45:master
Closed

Finished Cake project#148
Texx45 wants to merge 4 commits into
CodeYourFuture:masterfrom
Texx45:master

Conversation

@Texx45

@Texx45 Texx45 commented Jun 9, 2021

Copy link
Copy Markdown

No description provided.

@SteveLeicester

Copy link
Copy Markdown

Nicely done Terry.

Your semantic HTML looks good with header, navigation, footer and a number of sections. Would be nice to have these sections wrapped up as the main content in a main element.

As pages get more complex its good to remove unused pieces - <div id="wave"></div> doesn't seem to do anything.

The mobile site looks spot on. Nice drop down menu - did you do that as a stretch? Looks ideal for a fade in transition but I'm sure there will be opportunities later on to do that.

The browser based site seems fine though the alignment could be better - specifically the Welcome header and text to the right of the two cake image. There is a lot of padding above the text so it falls below the image. Other than that good stuff and thanks for completing this homework.

Steve

@Texx45

Texx45 commented Jun 21, 2021

Copy link
Copy Markdown
Author

Thanks for the feedback Steve, I have to admit I found it quite challenging (mainly positioning of elements). The drop down menu was a stretch goal and the id=wave was a cosmetic feature I was playing with but must have forgot to remove that part.

@github-actions

github-actions Bot commented Aug 3, 2021

Copy link
Copy Markdown

Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback.

@github-actions github-actions Bot added the Stale label Aug 3, 2021
@github-actions github-actions Bot closed this Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants