Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Resposive-cake-webpage - #1

Closed
MahmutSel404 wants to merge 5 commits into
CodeYourFuture:masterfrom
MahmutSel404:master
Closed

Resposive-cake-webpage#1
MahmutSel404 wants to merge 5 commits into
CodeYourFuture:masterfrom
MahmutSel404:master

Conversation

@MahmutSel404

Copy link
Copy Markdown

No description provided.

@LucyMac

LucyMac commented Feb 8, 2020

Copy link
Copy Markdown
Contributor

Hi Mahmut,
I hope you've managed to link your CSS file to your project 🙂
Can you push your latest changes?
Also, please change the name of your PR to describe what you're making.
Thanks

@LucyMac LucyMac added the waiting for changes A teacher has requested that you make some changes to your work label Feb 8, 2020
@MahmutSel404

Copy link
Copy Markdown
Author

Hi Lucy, I have just completed some part of homework. There is a lot more work to do but before class at least i can push this one. thanksss :)

@LucyMac LucyMac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @MahmutSel, thanks for pushing your changes 🙂

Now you can add some media queries to make the 4 cake boxes sit in a row on desktop.

Comment thread style.css Outdated
}
header nav ul {
margin:20px 0px 0px 20px;
float:right;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use floats - use flexbox instead!

Comment thread style.css Outdated
}
header nav ul li {
display:inline-block;
float:left;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use floats - use flexbox instead!

Comment thread style.css Outdated
}
.index-banner h1{
display:center;
width:1000px;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking your page layout because the rule applies even when the screen size is smaller than 1000px.
Can you remove it and make the layout work using flexbox?

@MahmutSel404

Copy link
Copy Markdown
Author

Hi Lucy, I removed the 1000px scren size, it is better now. thanks. But I am not very succesfull at converting float to flexbox. I think i am missing some points but I couldnt find it where the problem is.

@MahmutSel404 MahmutSel404 changed the title Testing Resposive-cake-webpage Feb 23, 2020
HamedHejjo added a commit to HamedHejjo/HTML-CSS-Coursework-Week3 that referenced this pull request Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

waiting for changes A teacher has requested that you make some changes to your work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants