Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.

Donald Fagen - #89

Closed
TheCheekyGit wants to merge 1 commit into
CodeYourFuture:masterfrom
TheCheekyGit:master
Closed

Donald Fagen#89
TheCheekyGit wants to merge 1 commit into
CodeYourFuture:masterfrom
TheCheekyGit:master

Conversation

@TheCheekyGit

Copy link
Copy Markdown

Webpage created

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name:
  • Your City:
  • Your Slack Name:

Homework Details

  • Module:
  • Week:

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

Webpage created

@alastair87 alastair87 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work!!

Comment thread css/style.css
.introduction image {
position: center;
border-radius: 3rem;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use .introduction img to select the img tag. You might also want to shrink the image, for example you could use width: 50vw; to make it 50% of the browser width. Otherwise it is too large so it won't actually position itself in the centre.

Comment thread index.html
<h3><a href="https://www.facebook.com/DonaldFagenMusic"> Donald Fagen Facebook </a></h3>


</footer>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent and you've made good use of the semantic tags and CSS styling. The media queries appear to work correctly when I adjust the size of my browser window.

The only suggestion I would make is you might want to make your text smaller since at the moment it's very large and makes your content take up several screens, even on a large monitor.

@github-actions

Copy link
Copy Markdown

Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback.

@github-actions github-actions Bot added the Stale label Aug 13, 2021
@github-actions github-actions Bot closed this Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants