NorthWest Class - Alexandra Ciungan - HTML CSS Week 1 - #84
Conversation
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
| </body> | ||
| </html> | ||
| <div id="side"> |
There was a problem hiding this comment.
Although a navigation was not asked for in the assignment, remember to use semantic html tags. For navigation links, the parent element should be a nav element rather than a div. Using a nav would also remove the need to add the class of nav to your navigation links. You could target the navigation links in the stylesheet using the selector below:
nav a {
/* styles... */
}
It might also be better to have only navigation links in a nav and a menu toggle button (hamburger) if needed. Consider moving the image in this section to somewhere else, maybe the <header>. This would also solve the issue of the image and the links all flowing on the same line.
This portion of html also belongs inside the <body> because it is intended to be seen by the user.
| </div> | ||
| </section> | ||
| </body> | ||
| <footer> |
There was a problem hiding this comment.
The <footer> is intended to be seen by the user, so it should be nested inside the <body> element.
| <a href="#social" class="nav"><img src="http://png.findicons.com/files/icons/2260/iphone_toolbar/26/plus.png" width="12" class="xtra_icon"> Social</a> | ||
| </div> | ||
| <br> | ||
| <body> |
There was a problem hiding this comment.
Please include the following:
-
A page
<header>with a title and description for the site.- Maybe you could take the
.contentsection and convert this to your<header>?
- Maybe you could take the
-
An articles section with three articles, each including a title, summary and a link.
- It's great that you have separated your content using
<section>elements,
maybe you could swap these section elements for<article>elements and nest them inside a ````` element with the name of articles. Make sure your article elements each have a title, summary and a link.
- It's great that you have separated your content using
|
|
||
| <section id="social"> | ||
|
|
||
| <div> |
There was a problem hiding this comment.
Try to keep your html "shallow", by this I mean try not to create unneccesary nesting. This div does not serve any purpose as the elements inside it could be direct children of the #social element.
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?