This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Glasgow Class 6 - Malkit Benning - HTML/CSS - Week 1 - #285
Open
malkitbenning wants to merge 3 commits into
Open
Conversation
Added 3 articles with headers and links
added pseudo class to make first article stand out
Used Lorem Ipsum to pad out the web page with content.
SallyMcGrath
left a comment
Member
There was a problem hiding this comment.
Nice work, @malkitbenning !
| ultrices nulla accumsan eget. | ||
| </p> | ||
| <p>Below is a link to a video describing the technique in detail:</p> | ||
| <a href="https://www.youtube.com/watch?v=aHKt4sxZdXs">Click Here</a> |
Member
There was a problem hiding this comment.
You might enjoy this article https://www.smashingmagazine.com/2012/06/links-should-never-say-click-here/
| cursus diam. | ||
| </p> | ||
| <img | ||
| src="https://images.unsplash.com/photo-1659468480453-f04eb04661cb?ixlib=rb-4.0.3&ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&auto=format&fit=crop&w=1864&q=80 |
Member
There was a problem hiding this comment.
Suggested change
| src="proxy.php?url=https%3A%2F%2Fimages.unsplash.com%2Fphoto-1659468480453-f04eb04661cb%3Fixlib%3Drb-4.0.3%26amp%3Bixid%3DMnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8%26amp%3Bauto%3Dformat%26amp%3Bfit%3Dcrop%26amp%3Bw%3D1864%26amp%3Bq%3D80%3C%2Ftd%3E%0A++++++++++%3C%2Ftr%3E%0A++++++++++%3Ctr+class%3D"border-0"> | src="proxy.php?url=https%3A%2F%2Fimages.unsplash.com%2Fphoto-1659468480453-f04eb04661cb%3Fixlib%3Drb-4.0.3%26amp%3Bixid%3DMnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8%26amp%3Bauto%3Dformat%26amp%3Bfit%3Dcrop%26amp%3Bw%3D1864%26amp%3Bq%3D80%3Cspan+class%3D"x x-first x-last">" |
Looks like this is missing an end quote. Please make sure you have Prettier installed and checking your syntax. https://syllabus.codeyourfuture.io/guides/code-style-guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
Quite easy getting back into basic HTML and CSS. I liked the explanation about Inline and Block elements and the effect of margin and padding on inline elements.
What did you find hard?
The difference between sections and articles is tricky.
What do you still not understand?
I'm not 100% sure about how my work is to be marked / graded? Do we get a chance to re-work? If we are getting things wrong, how will we find out?
Any other notes?