London9-Elahe Mortazavi-HTML&CSS-courseworkweek1 - #250
Conversation
some changes applied.
There was a problem hiding this comment.
Hi Ellie, Nice work, I like the design and the fact that you wrote about something that you were passionate about. The following points from the question were not answered in this solution. See the comments in the review for more info.
-
A page header with a title and description for the site.
-
An articles section with three articles, each including a title, summary and a link.
-
Use this website Lorem Ipsum to generate random blocks of contents to fill your website. (You used real content for your articles, this is fine. But sometimes if you wish to just focus on the design and not the content, you can replace thae content with Lorem Ipsum)
More information about the <article> element and others can be found here
| <body id="all"> | ||
|
|
||
|
|
||
| <div class="head"> |
There was a problem hiding this comment.
Should use <header> element here instead.
| </div> | ||
| </div> | ||
| <main class="flex"> | ||
| <div class="main" id="articles"> |
There was a problem hiding this comment.
here you can use the <section> element
| </div> | ||
| <main class="flex"> | ||
| <div class="main" id="articles"> | ||
| <div class="part1"> |
There was a problem hiding this comment.
here you can use the <article> element
|
|
||
| <p class="footer">Made with Love by Elahe</p> | ||
| </footer> | ||
|
|
There was a problem hiding this comment.
Good to remove all empty whitelines
| <main class="flex"> | ||
| <div class="main" id="articles"> | ||
| <div class="part1"> | ||
| <div class="acu"> |
There was a problem hiding this comment.
You can add more than 1 class to any div, so that you do not have so many nested divs i.e <div class="part1 acu" > or <article class="part1 acu" >
| <img class="acu-img" src="/images/pexels-antoni-shkraba-6076146.jpg"> | ||
| <div class=""> | ||
| <h2>Acupuncture History</h2> | ||
| <h4>Past, Present, and Future</h4> |
There was a problem hiding this comment.
Generally, not a good idea to skip heading levels, i.e. h2->h4, skipping h3. And do not use h1,h2,h3 etc for font size or style. h1,h2,h3 are for meaning: h1 is the main header, h2 is a subheader, h3 is a subheader within h2. If you want to adjust the font size or font style, use css
| border-radius: 5px; | ||
|
|
||
| } | ||
| .acu2 { |
There was a problem hiding this comment.
Indentation from here is not correct. If something is not nested it should be all the way to the left
I have created my Acupuncture Blog.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?