London class 9 -Mickey Haile - HTM/CSS -week 1 - #243
Conversation
|
try and make sure to fill out the template body; knowing what you find hard/easy or any sticking points is really useful for us :P |
JDysiewicz
left a comment
There was a problem hiding this comment.
looking good so far, add a couple more article tags and use the pseudo selector first child to style the first article.
| <ul class="arty2">Fun Facts About Rabbits</ul> | ||
|
|
||
|
|
||
| <Li>To express happiness, bunnies will sometimes jump around and flick their heads and feet. ...</li> | ||
| <li>Like deer, a female rabbit is called a “doe” and a male rabbit is called a “buck.”</li> | ||
| <li> bunny's big ears aren't just for listening! ...</li> | ||
| <li> those amazing ears can also be rotated almost a full circle to 270 degrees.</li> |
There was a problem hiding this comment.
your ul should wrap your list items to make the structure easier to parse - e.g.
<ul class="arty2">
<li>Some text</li>
<li>some other text</li>
</ul>
| <iframe width="695" height="391" src="https://youtu.be/XF4TimSeGiU" | ||
| title="Thing you need to know about rabbits" frameborder="0" | ||
| allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe> |
There was a problem hiding this comment.
nice use of an iframe to make the site a bit more dynamic
|
|
||
|
|
||
| .hello{ | ||
| font-size: 100px; |
There was a problem hiding this comment.
100px is very large for a font size 😅
| .hello1{ | ||
| font-size: 100px; | ||
| text-align: center; | ||
| padding-left: 20px; | ||
| padding-right: 20px; | ||
| font-size: 18px; | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
instead of repeating the same stylings for multiple different classes, you can apply the styling to a single class, and apply multiple classes to an element (e.g. <div class="mystyling hello1">)
| <br> | ||
| <div class="arty"> | ||
| <h2 class=" links">Summary</h2> | ||
| <article>When you look at the rabbits they inspire us to look after our enviroment therefore we must protect this precious species <br>as they |
There was a problem hiding this comment.
nice use of an article here, although you need to add a couple more article tags, and use the pseudo selector first child to style the first one
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?