London9-OlehPysmenko-Week1 - #240
Conversation
| /* hero */ | ||
|
|
||
| .hero { | ||
| height: 80px; |
There was a problem hiding this comment.
you are limiting the height of the div but the content of the children is too long for the height suggested. so it is actually not fitting in the space of the 80px. And you probably don't want put any restriction on the height of this
| } | ||
|
|
||
| .scooter-background { | ||
| position: relative; |
There was a problem hiding this comment.
normally you would have the whole image as vector, included with background image and shadow. What you are trying to achieve is way harder cause you are recreating the whole design from scratch but with css, and is pushing you to use a lot of relative and absolute positioning which makes more complex having a responsive design
|
it is very good! Nice jobs. I think you made your life harder with reassembling the image yourself, but other than that it is great. The Loom I sent you last time and some comments are just for details |
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?