London9 - Marziyeh Azhdari - HTML/CSS - Week 1 - #239
Conversation
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
| <div class="header"> | ||
|
|
||
| <div class="topnav"> |
There was a problem hiding this comment.
Try to indent your code so that it is more clear to read. Here, the div topnav is inside the div header. It would be easier to read if header was not indented and topnav was.
| <div class="leftcolumn"> | ||
| <div class="card"> | ||
| <h2>About Iran:</h2> | ||
| <h5>Iran, a mountainous, arid, and ethnically diverse country of southwestern Asia. Much of Iran consists of a central desert plateau, which is ringed on all sides by lofty mountain ranges that afford access to the interior through high passes. Most of the population lives on the edges of this forbidding, waterless waste. The capital is Tehrān, a sprawling, jumbled metropolis at the southern foot of the Elburz Mountains. Famed for its handsome architecture and verdant gardens, the city fell somewhat into disrepair in the decades following the Iranian Revolution of 1978–79, though efforts were later mounted to preserve historic buildings and expand the city’s network of parks. As with Tehrān, cities such as Eṣfahān and Shīrāz combine modern buildings with important landmarks from the past and serve as major centres of education, culture, and commerce.</h5> |
There was a problem hiding this comment.
This should probably be a paragraph. Also, if you have a long paragraph, you can divide it in multiple sentences in the html file. The browser will ignore these new lines, so feel free to break into short sentences. This makes it easier to review also.
| <p><a href="https://en.wikipedia.org/wiki/Iran"><i class="fa fa-wikipedia-w"></i></a></p> | ||
|
|
||
|
|
||
| </div> |
There was a problem hiding this comment.
Here again, is important to use indentation correctly. It is unclear if this div closes the one in line 64 or in line 62 based on indentation.
| .active3{ | ||
| background-color: #cf3345; | ||
| color: white; | ||
| } |
There was a problem hiding this comment.
I loved how you played with active 1, 2, and 3, so that the colors make the flag of Iran. Such a cool idea!
| .topnav { | ||
| overflow: hidden; | ||
| background-color: rgb(92, 81, 81); | ||
|
|
There was a problem hiding this comment.
No need for an extra empty line there. This is a very small thing, but in general we try to follow a consistent style when writing code. There probably should not be an empty line before closing the }.
| <a class="active2" href="#contact">Contact</a> | ||
| <a class="active3" href="#about">About me</a> | ||
| </div> | ||
| <h2>Iran</h2> |
There was a problem hiding this comment.
I feel like it would probably make more sense for this to be a h1, and then leave the h2 two for the titles of the articles. Then, when you use the :first-child pseudo-class, the first articule title would stand out.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
It dose not clear.
What do you still not understand?
Any other notes?
Was interesting.