This repository was archived by the owner on Jan 14, 2024. It is now read-only.
West Midlands Class 3 - Tenzin Samdup - HTML/CSS - Week 1 - #103
Closed
tenzyns wants to merge 7 commits into
Closed
Conversation
Added header and body content including image, paragraph, navigation links.
Includes footer navigation links.
Added logo image, address and started on header styles including navigation links and background colour.
Styled header part, navigation link's CSS styling.
In html, I changed logo image as the previous link broke; added a new class .text-color, replaced article element with main element; I removed span element as flex display created unwanted column; In CSS, i added comments for some selectors; edited :first-child selector; updated background color;
Updated links to open them on a new tap. updated the introduction in the header section.
Added link hover colour and added more comments to CSS selectors.
|
Your coursework submission has been closed because nobody has interacted with it in six weeks. You are welcome to re-open it to get more feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title for your pull request should be made in this format
CITY CLASS_NO - FIRST_NAME LAST_NAME - MODULE - WEEK_NO
For example,
London Class 7 - Chris Owen - HTML/CSS - Week 1
Please complete the details below this message
-->
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
The HTML part was quite easy
What did you find hard?
I wanted to style each section with different margin or padding. It was not working probably because I had already assigned the same class to all of them.
What do you still not understand?
I couldn't get the image id of the logo to work in the CSS. Only when I used the parent element's ID and the image element as the selector(#nav-bar img{}), it worked. I don't understand why.
Any other notes?