Skip to content
This repository was archived by the owner on Oct 2, 2024. It is now read-only.

Homework - Ivan Zhukov - Scotland Class 5 - #35

Closed
zhkvivan wants to merge 2 commits into
CodeYourFuture:mainfrom
zhkvivan:main
Closed

Homework - Ivan Zhukov - Scotland Class 5#35
zhkvivan wants to merge 2 commits into
CodeYourFuture:mainfrom
zhkvivan:main

Conversation

@zhkvivan

@zhkvivan zhkvivan commented Jun 4, 2021

Copy link
Copy Markdown

@sriram-siv

Copy link
Copy Markdown

This looks really good, nice job Ivan.
Just a few small things that could be improved upon:

  • Letter spacing as mentioned in exercise 1 hasn't been applied. There are two properties you can use for this: line-height and letter-spacing. This is a really good one to be aware of, it's quite a subtle effect but can make pages look much nicer.
  • Exercise 3 asks to change the contrast but doesn't have the link attached. You can find a tool for this here, with an explanation of how to use it.
  • The paragraph for ex.7 needs to be centred correctly. If you add something like margin: 30px auto, then the left and right margins will automatically be made the same size (with a vertical margin of 30px in this example)
  • The links in ex.8 need to all open in a new tab. The second one already works this way if you need a reminder on how to do this.

@bonboh bonboh closed this Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants