Skip to content

[Implement] HEX Encoding: decode, decodeUnsafe, encode - #17

Merged
jtenner merged 6 commits into
masterfrom
hex
Aug 1, 2019
Merged

[Implement] HEX Encoding: decode, decodeUnsafe, encode#17
jtenner merged 6 commits into
masterfrom
hex

Conversation

@jtenner

@jtenner jtenner commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

TODO:

  • More testing?
  • Optimization?
  • check types

@jtenner jtenner added the enhancement New feature or request label Jul 24, 2019
@jtenner jtenner self-assigned this Jul 24, 2019
@jtenner jtenner changed the title [Implement] decode, decodeUnsafe, encode [Implement] HEX Encoding: decode, decodeUnsafe, encode Jul 24, 2019
@jtenner
jtenner requested a review from dcodeIO July 25, 2019 15:10
Comment thread assembly/buffer/index.ts
Comment thread assembly/buffer/index.ts Outdated
Comment thread assembly/node.d.ts Outdated
Comment thread assembly/node.d.ts Outdated
Comment thread assembly/node.d.ts Outdated
Comment thread assembly/buffer/index.ts Outdated
Comment thread assembly/buffer/index.ts
@jtenner

jtenner commented Jul 29, 2019

Copy link
Copy Markdown
Contributor Author

@dcodeIO I intend on pulling this request. I can't find much else to improve. That could be because of my lack of experience, but your eyes tend to catch lots of little things I miss.

Thoughts?

@jtenner
jtenner merged commit 9027d73 into master Aug 1, 2019
@dcodeIO
dcodeIO deleted the hex branch June 1, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants