You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the review @MaxGraey! I just implemented the split. I have a doubt on types in the std because the div_s and div_u have both a i32/64 type for the parameters. It should be u32/64 right? Even if the compiler will reinterpret those types later (if I understand correctly 😄 ).
MaxGraey
changed the title
Add rem builtin for i33 and i64 (#1310)
Add rem builtin for i32 and i64 (#1310)
Jun 5, 2022
Thanks, looks good, just a few nits on wording above :)
Regarding
I have a doubt on types in the std because the div_s and div_u have both a i32/64 type for the parameters. It should be u32/64 right? Even if the compiler will reinterpret those types later (if I understand correctly 😄 ).
In the .d.ts, the numeric types are merely aliases of number, so I guess that's why the discrepancy hasn't been noticed before. Doesn't harm to unify these, as you suggest. Perhaps as another PR?
In the .d.ts, the numeric types are merely aliases of number, so I guess that's why the discrepancy hasn't been noticed before. Doesn't harm to unify these, as you suggest. Perhaps as another PR?
Thanks for your review! I can change that in another PR as you said 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the builtin
remfori32andi64, requested in the issue #1310