Skip to content

TRD: correction for pile-up#15282

Open
glegras wants to merge 5 commits intoAliceO2Group:devfrom
glegras:trdtracking
Open

TRD: correction for pile-up#15282
glegras wants to merge 5 commits intoAliceO2Group:devfrom
glegras:trdtracking

Conversation

@glegras
Copy link
Copy Markdown
Contributor

@glegras glegras commented Apr 15, 2026

No description provided.

Comment thread Detectors/TRD/qc/src/Tracking.cxx Outdated
auto& tRecord = (isTPCTRD ? mTrackTriggerRecordsTPCTRD[mCurrentTriggerRecord] : mTrackTriggerRecordsITSTPCTRD[mCurrentTriggerRecord]);
if (mCurrentTrackId >= tRecord.getFirstTrack() && mCurrentTrackId < tRecord.getFirstTrack() + tRecord.getNumberOfTracks()) {
uint32_t currentOrbit = tRecord.getBCData().orbit;
triggeredBC = tRecord.getBCData().bc + (currentOrbit - mFirstOrbit) * o2::constants::lhc::LHCMaxBunches;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use the method tRecord.getBCData().differenceInBC({0, mFirstOrbit});

}
if (o2::ft0::InteractionTag::Instance().isSelected(f0rec)) {
uint32_t currentOrbit = f0rec.getInteractionRecord().orbit;
triggeredBCFT0.push_back(f0rec.getInteractionRecord().bc + (currentOrbit - firstOrbit) * o2::constants::lhc::LHCMaxBunches);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem, could be f0rec.getInteractionRecord().differenceInBC({0,firstOrbit})

Comment on lines +86 to +88
int mPileUpRangeBefore{-130}; ///< maximal number of BC for which pile-up from previous collision has an influence
int mPileUpMaxProb{0}; ///< number of BC with respect to triggered BC for the event with maximal probability
int mPileUpRangeAfter{70}; ///< maximal number of BC for which pile-up from next collision has an influence
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These numbers are different wrt those in the

AddOptionRTC(pileupFwdNBC, uint8_t, 80, "", 0, "Post-trigger Pile-up integration time in BCs")
AddOptionRTC(pileupBwdNBC, uint8_t, 80, "", 0, "Pre-trigger Pile-up integration time in BCs")
, used to define the timestamp errors of the track. Do we need to adjust them? In any case, would be better to avoid duplications.

@glegras glegras marked this pull request as ready for review April 20, 2026 15:37
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 0051b36 at 2026-04-20 20:10:

## sw/BUILD/O2-latest/log
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants