Skip to content

DPL: Fix memory leak in variant_helper #13051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Apr 22, 2024
Merged

DPL: Fix memory leak in variant_helper #13051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
DPL: Fix memory leak in variant_helper
  • Loading branch information
@ktf
ktf committed Apr 19, 2024
commit 69b5961c1ceba53e2222c35728208ebe15c92d12
2 changes: 1 addition & 1 deletion Framework/Core/include/Framework/Variant.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ struct variant_helper<S, std::string_view> {

template <typename S>
struct variant_helper<S, std::string> {
static std::string get(const S* store) { return std::string(strdup(*reinterpret_cast<const char* const*>(store))); }
static std::string get(const S* store) { return std::string(*reinterpret_cast<const char* const*>(store)); }

static void set(S* store, std::string value) { *reinterpret_cast<char**>(store) = strdup(value.data()); }
};
Expand Down