Update apm.py - #1
Merged
Merged
Conversation
Add option to not print output from APM cmd. In a perfect world, I think it might be best to adjust the return value of method to return a tuple of `(response, output)` so the caller can do what they will with the output, or something similar, but that will likely cause a fair amount of refactoring. This change should keep the default behavior while allowing to opt out from printing input, for example when running APM from Gekko. I haven't spent an inordinate amount of time thinking over this change, so feedback is certainly welcome :)
Add same change to Python 3 branch
Add comment to Python 2 branch as well
loganbeal
approved these changes
Feb 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to not print output from APM cmd. In a perfect world, I think it might be best to adjust the return value of method to return a tuple of
(response, output)so the caller can do what they will with the output, or something similar, but that will likely cause a fair amount of refactoring.This change should keep the default behavior while allowing to opt out from printing input, for example when running APM from Gekko. I haven't spent an inordinate amount of time thinking over this change, so feedback is certainly welcome :)