Skip to content
This repository was archived by the owner on Jan 17, 2023. It is now read-only.

Conversation

@SlaunchaMan
Copy link
Contributor

Required to make an update to the 2.x release.

@SlaunchaMan SlaunchaMan added this to the 2.7 milestone Dec 7, 2018
@sashaweiss
Copy link

Hey all, just wanted to check in post-holidays and see if there had been any movement on this, or if I could lend a hand?

Thanks so much!

@SlaunchaMan
Copy link
Contributor Author

I’d definitely appreciate a second set of eyes on these Travis failures! I’m trying to get Travis running on the 2.x branch to validate the other fixes.

SlaunchaMan and others added 11 commits February 9, 2019 11:31
This pattern does not make sense at all because the assert can never fail.

if (condition) {
    XCTAssert(condition, @"comment");
}
Do not use XCTAssertEqual(reachable, ...) because it might transition to AFNetworkReachabilityStatusNotReachable before becoming reachable.
The status passed in callbacks (both block and notification) is captured before the callbacks are dispatched on the main thread. It is thus possible that the reachabilityManager status change in the meantime.

Users MUST use the status parameter for the block callback or the `AFNetworkingReachabilityNotificationStatusItem` user info key for the notification.
@SlaunchaMan SlaunchaMan merged commit 0375f0f into 2.x Feb 12, 2019
@SlaunchaMan SlaunchaMan deleted the update-2.x-travis-settings branch February 12, 2019 02:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants