gh-155504: Set the interpreter before fallible thread state initialization - #155590
Merged
kumaraditya303 merged 3 commits intoAug 16, 2026
Merged
Conversation
abdulm5
marked this pull request as ready for review
August 12, 2026 15:20
abdulm5
requested review from
FFY00,
ZeroIntensity and
ericsnowcurrently
as code owners
August 12, 2026 15:20
kumaraditya303
approved these changes
Aug 15, 2026
Contributor
|
You need to sign CLA |
|
Thanks @abdulm5 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
Thanks @abdulm5 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
GH-155884 is a backport of this pull request to the 3.15 branch. |
|
GH-155885 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alloc_threadstate()returned a reset thread state withbase.interpstillset to
NULL. If one of the later PyStats, TLBC, or QSBR initialization stepsfailed,
new_threadstate()passed that partially initialized state tofree_threadstate(). The cleanup path needs the interpreter both to identifythe embedded initial thread state and to release interpreter-owned resources.
Set
base.interpinalloc_threadstate()before any later initialization canfail, so every error path can safely free or recycle the thread state.
The change also adds a Core and Builtins NEWS entry.
Fixes #155504.
Tests
./python.exe -m test -j4 --timeout=180 test_capi test_interpreters test_threading test_embed(2,001 tests passed)
./python.exe -m test -j4 --timeout=180 test_pystats test_capi test_interpreters test_threading test_embed(1,836 tests passed;
test_interpreterswas skipped because the GIL was disabled)and heap-allocated thread state paths; the injection was removed afterward.
git diff --check