refactor(core): replace createWatch usages in tests with custom ReactiveNode - #70242
Draft
JeanMeche wants to merge 1 commit into
Draft
refactor(core): replace createWatch usages in tests with custom ReactiveNode#70242JeanMeche wants to merge 1 commit into
JeanMeche wants to merge 1 commit into
Conversation
JeanMeche
force-pushed
the
refactor-signals-test-effects
branch
from
August 17, 2026 20:00
fb1d13a to
35e1ba3
Compare
JeanMeche
force-pushed
the
refactor-signals-test-effects
branch
from
August 17, 2026 20:00
35e1ba3 to
698a066
Compare
…iveNode Replace usages of createWatch in signal tests by creating a custom ReactiveNode implementing BaseEffectNode and extending BASE_EFFECT_NODE. This aligns the test effect utilities with how effects are implemented in core today.
JeanMeche
force-pushed
the
refactor-signals-test-effects
branch
from
August 17, 2026 20:12
698a066 to
f959287
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace usages of
createWatchin signal tests by creating a customReactiveNodeimplementingBaseEffectNodeand extendingBASE_EFFECT_NODE.This aligns the test effect utilities with how effects are implemented in core today.