feat(core): add scrollMargin to @defer viewport options - #70187
Open
SkyZeroZx wants to merge 1 commit into
Open
Conversation
SkyZeroZx
marked this pull request as ready for review
August 13, 2026 21:57
SkyZeroZx
marked this pull request as draft
August 13, 2026 21:58
SkyZeroZx
marked this pull request as ready for review
August 13, 2026 21:58
crisbeto
approved these changes
Aug 15, 2026
Member
|
This is breaking our internal tests, because |
Contributor
Author
If I remember correctly, scrollMargin was added in TypeScript 6.0. Maybe G3 is using an older version of TypeScript? While adding it to the types manually might be an alternative, I'm not sure if there would be any problems or if it should only be done in G3. Or should it be done on the Angular side? |
JeanMeche
reviewed
Aug 16, 2026
JeanMeche
force-pushed
the
feat-viewport-scrollMargin
branch
from
August 16, 2026 17:42
07afc2b to
358521f
Compare
Allow `scrollMargin` to be configured for `@defer` viewport, prefetch, and hydrate triggers. Unlike `rootMargin`, `scrollMargin` expands the clipping bounds of nested scroll containers. This allows deferred content to be loaded or prefetched before it enters the visible area of a nested scroller. Include `scrollMargin` in the IntersectionObserver cache key so viewport triggers with different margins use the correct observer configuration.
SkyZeroZx
force-pushed
the
feat-viewport-scrollMargin
branch
from
August 16, 2026 19:36
358521f to
1b512bf
Compare
JeanMeche
approved these changes
Aug 16, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
scrollMarginto be configured for@deferviewport, prefetch, and hydrate triggers.Unlike
rootMargin,scrollMarginexpands the clipping bounds of nested scroll containers. This allows deferred content to be loaded or prefetched before it enters the visible area of a nested scroller.Include
scrollMarginin the IntersectionObserver cache key so viewport triggers with different margins use the correct observer configuration.