chore: remove dead --download-mode package - #223
Open
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Open
chore: remove dead --download-mode package#223Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
Conversation
The mode built GET /patch/package/<uuid> (proxy) or GET /v0/orgs/<slug>/patches/package/<uuid> (authenticated) — routes no deployed server has served since the on-demand package flow was dropped (depscan e2e test 80 pins their absence). Every package-mode fetch failed per-UUID and silently degraded to per-file blob downloads: slower, noisier, and never what the flag promised. Now `--download-mode package` / `SOCKET_DOWNLOAD_MODE=package` fails fast with a removal notice instead of degrading. The local `.socket/packages/` read path in the apply pipeline is intentionally untouched — pre-staged archives still apply. Removed: DownloadMode::Package, ArchiveKind (collapsed to diff-only fetch), ApiClient::fetch_package. Tests updated to pin the removal error and that repair in package mode hard-fails without touching the package archive route. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Claude Code:claude-fable-5
Cleanup from the 2026-08-19 patches-api-proxy architecture review (depscan side landed as SocketDev/depscan#24484).
What
--download-mode packagetargetedGET /patch/package/<uuid>on the public proxy andGET /v0/orgs/<slug>/patches/package/<uuid>authenticated — routes no deployed server serves (the proxy's catch-all 400s the GET, api-v0's package surface is POST-only, and depscan e2e test 80 explicitly pins the route's absence). Every package-mode archive fetch failed per-UUID and then silently degraded to per-file blob downloads — slower, noisier, and never what the flag promised.DownloadMode::Package,ArchiveKind(archive fetch collapsed to diff-only), andApiClient::fetch_packageare gone.--download-mode package/SOCKET_DOWNLOAD_MODE=packagenow fails fast with a targeted removal notice (download mode 'package' was removed; use diff or file) instead of degrading — distinct from the generic unknown-mode error.POST /patch/packagevendor-service flow (vendor_package_url) is unrelated and untouched..socket/packages/read path in the apply pipeline is intentionally untouched: pre-staged archives still apply; only the download mode that could never populate that directory is removed.--helptext updated; tests now pin the removal error, and the repair lifecycle test asserts package mode hard-fails without ever hitting the package archive route.What was deliberately NOT removed
The review also flagged
before_blob_content/include_before_blobsas dead end-to-end (no production caller sends the query param, so the server never populates the field). I started removing it and backed out: a dozen in-process suites (gem multi-platform rollback, pypi multi-release, get manifest flows) deliberately exercise the rollback pre-cache design built on inline before-blobs — the plumbing is load-bearing in the CLI's rollback semantics, just unreachable in prod because nothing triggers the server side. Making it live (sendinclude_before_blobs=trueon the authenticated get path) is a product/payload-size decision, not cleanup — left for a separate call.Validation
cargo build --workspace --all-targetsclean; fullcargo test --workspacegreen (2404 core lib tests + all e2e/in-process suites, zero failures).🤖 Generated with Claude Code
Note
Medium Risk
Changes patch artifact download behavior and telemetry endpoint resolution for on-prem
--api-urlruns; scope is CLI/core fetch paths with broad test updates, not auth or data persistence.Overview
Removes
--download-mode package/SOCKET_DOWNLOAD_MODE=packageas a supported artifact fetch path. The mode targeted GET package-archive routes that no deployed server serves, so runs always failed per patch and fell back to per-file blobs.DownloadMode::Package,ApiClient::fetch_package, and the package-archive download branch infetch_missing_sourcesare deleted;diffandfileremain. Choosingpackagenow fails atDownloadMode::parsewith an explicit removal message instead of degrading silently.Docs and help text now describe only
diff(default) andfile.repair,fetch_stage, and tests are aligned with the two-mode model; repair hard-fails package mode before any network I/O.apply_env_togglesnow mirrors non-empty--api-url/--proxy-urlintoSOCKET_API_URL/SOCKET_PROXY_URLso telemetry (which reads env only) does not POST to the defaultapi.socket.devwhen the operator set an on-prem base. API token and org are still not mirrored to avoid leaking secrets into child processes. The previously ignored regression test for this mirror is enabled.Local reads of pre-staged
.socket/packages/archives in the apply pipeline are intentionally unchanged; only the dead download mode is removed.Reviewed by Cursor Bugbot for commit 92c2b3c. Configure here.