Skip to content

fix(core): detach SegmentedBar/TabView items from a previous parent before adopting them #11353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 2 commits into from
Aug 17, 2026
+75 −1
Merged

fix(core): detach SegmentedBar/TabView items from a previous parent before adopting them #11353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
999b456
fix(segmented-bar): detach items from a previous parent before adopti…
edusperoni Aug 17, 2026
682aeba
fix(tab-view): detach items from a previous parent before adopting them
edusperoni Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions apps/automated/src/ui/segmented-bar/segmented-bar-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,39 @@ export function test_SettingNumberAsTitleFromXML_DoesNotThrow() {
});
}

export function test_SettingTheSameItemsToAnotherSegmentedBar_DoesNotThrow() {
const items = _createItems(3);
const firstBar = _createSegmentedBar();

buildUIAndRunTest(firstBar, function (views: Array<View>) {
firstBar.items = items;

const secondBar = _createSegmentedBar();
secondBar.items = items;

items.forEach((item, i) => TKUnit.assertEqual(item.parent, secondBar, `Item ${i} should be parented to the SegmentedBar it was last assigned to.`));
});
}

export function test_SettingTheItemsOfATornDownSegmentedBarToANewOne_DoesNotThrow() {
const items = _createItems(3);
const firstBar = _createSegmentedBar();

buildUIAndRunTest(firstBar, function (views: Array<View>) {
firstBar.items = items;
});

// The test above leaves the page without content, so firstBar is torn down while its items still point at it.
const secondBar = _createSegmentedBar();

buildUIAndRunTest(secondBar, function (views: Array<View>) {
secondBar.items = items;

items.forEach((item, i) => TKUnit.assertEqual(item.parent, secondBar, `Item ${i} should be parented to the SegmentedBar it was last assigned to.`));
TKUnit.assertEqual(segmentedBarTestsNative.getNativeItemsCount(secondBar), items.length, 'Native items should be created for the SegmentedBar the items were re-assigned to.');
});
}

/*export function testBackgroundColorUpdatedAfterItemSelected() {
let segmentedBar = new segmentedBarModule.SegmentedBar();
let item1 = new segmentedBarModule.SegmentedBarItem();
Expand Down
30 changes: 30 additions & 0 deletions apps/automated/src/ui/tab-view/tab-view-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,36 @@ export class TabViewTest extends UITest<tabViewModule.TabView> {
}, 'Binding TabView to a TabViewItem with null view should throw.');
};

public test_SettingTheSameItemsToAnotherTabView_DoesNotThrow = function () {
var tabView = this.testView;
var items = this._createItems(2);
tabView.items = items;
this.waitUntilTestElementIsLoaded();

var secondTabView = new tabViewModule.TabView();
secondTabView.items = items;

items.forEach((item, i) => TKUnit.assertEqual(item.parent, secondTabView, `Item ${i} should be parented to the TabView it was last assigned to.`));
};

public test_SettingTheItemsOfATornDownTabViewToANewOne_DoesNotThrow = function () {
var tabView = this.testView;
var items = this._createItems(2);
tabView.items = items;
this.waitUntilTestElementIsLoaded();

// Detaching the TabView tears it down, but its items still point at it.
this.testPage.content = null;

var secondTabView = new tabViewModule.TabView();
secondTabView.items = items;
this.testPage.content = secondTabView;
TKUnit.waitUntilReady(() => secondTabView.isLoaded, 1);

items.forEach((item, i) => TKUnit.assertEqual(item.parent, secondTabView, `Item ${i} should be parented to the TabView it was last assigned to.`));
TKUnit.assertEqual(tabViewTestsNative.getNativeTabCount(secondTabView), items.length, 'Native tabs should be created for the TabView the items were re-assigned to.');
};

public testWhenSelectingATabNativelySelectedIndexIsUpdatedProperly = function () {
var tabView = this.testView;
tabView.items = this._createItems(2);
Expand Down
8 changes: 7 additions & 1 deletion packages/core/ui/segmented-bar/segmented-bar-common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,13 @@ export abstract class SegmentedBarBase extends View implements SegmentedBarDefin

if (newItems) {
for (let i = 0, count = newItems.length; i < count; i++) {
this._addView(newItems[i]);
const item = newItems[i];
// A view can only have one parent, and _addView throws if it already has one.
if (item.parent && item.parent !== this) {
item.parent._removeView(item);
}

this._addView(item);
}
}
}
Expand Down
5 changes: 5 additions & 0 deletions packages/core/ui/tab-view/tab-view-common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,11 @@ export class TabViewBase extends View implements TabViewDefinition, AddChildFrom
throw new Error(`TabViewItem must have a view.`);
}

// A view can only have one parent, and _addView throws if it already has one.
if (item.parent && item.parent !== this) {
item.parent._removeView(item);
}

this._addView(item);
});
}
Expand Down
Loading