Skip to content

Added semicolon after output - #830

Merged
sokra merged 1 commit into
webpack:masterfrom
hkal:semicolon-guard
Feb 27, 2015
Merged

sokra merged 1 commit into
webpack:masterfrom
hkal:semicolon-guard

Conversation

@hkal

@hkal hkal commented Feb 27, 2015

Copy link
Copy Markdown
Contributor

This fixes #789. However, @sokra mentioned that dependencies should just be bundled together instead of trying to concat bundles.

sokra added a commit that referenced this pull request Feb 27, 2015
Added semicolon after output
@sokra
sokra merged commit 3ae1736 into webpack:master Feb 27, 2015
@sokra

sokra commented Feb 27, 2015

Copy link
Copy Markdown
Member

Thanks

@DavidSouther

Copy link
Copy Markdown

@sokra "should" being the operative word - as mentioned in #789, the fact that the underlying dependencies had been built with webpack does not mean that the consuming project then must use webpack. @hkal thank you very much for the fix!

@hkal
hkal deleted the semicolon-guard branch February 28, 2015 15:29
@sokra

sokra commented Feb 28, 2015

Copy link
Copy Markdown
Member

hmm... seem to be broken...

@sokra

sokra commented Feb 28, 2015

Copy link
Copy Markdown
Member

by @boopathi

(function(e, a) { for (var i in a) e[i] = a[i]; }(this, webpackJsonp([0], {
    0: function(module, exports, __webpack_require__) {},
    33:function(module, exports, __webpack_require__) {}
});))
//^ Syntax Error - Unexpected token ;

@sokra

sokra commented Feb 28, 2015

Copy link
Copy Markdown
Member

ups no... It was another bug...

@sokra

sokra commented Feb 28, 2015

Copy link
Copy Markdown
Member

PR is (propably) fine...

sokra added a commit that referenced this pull request Mar 3, 2015
@sokra

sokra commented Mar 3, 2015

Copy link
Copy Markdown
Member

ok it wasn't fine... but I fixed it...

@hkal

hkal commented Mar 4, 2015

Copy link
Copy Markdown
Contributor Author

Whoops. Thanks for cleaning up my mistake.

@boopathi

boopathi commented Mar 5, 2015

Copy link
Copy Markdown

Works! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error concatenating two webpack libraries.

4 participants