SideEffectsPlugin don't modify cache entries - #7408
Merged
Merged
Conversation
Contributor
|
For maintainers only:
|
sokra
force-pushed
the
bugfix/side-effects-caching
branch
from
May 27, 2018 19:50
0681fe6 to
a297c48
Compare
sokra
force-pushed
the
bugfix/side-effects-caching
branch
from
May 27, 2018 19:53
a297c48 to
ae8d674
Compare
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ooflorent
reviewed
May 28, 2018
| for (const chunk of compilation.chunks) { | ||
| if (chunk.entryModule) { | ||
| processModule(chunk.entryModule, true); | ||
| for (const preparedEntrypoint of compilation._preparedEntrypoints) { |
Contributor
There was a problem hiding this comment.
It is possible to use compilation.entrypoints instead?
Member
Author
There was a problem hiding this comment.
Sadly not, as this plugin runs before these property is set. But we should make _preparedEntrypoints public in the next major version
Contributor
There was a problem hiding this comment.
Thanks for clarification. Since _preparedEntrypoints is a private API, isn't it safe to change it now?
Member
Author
There was a problem hiding this comment.
Technically yes, but I better don't risk it...
ooflorent
approved these changes
May 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix bug where modules are incorrectly including in chunks
fixes #7400
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
yes, but its a bugfix
What needs to be documented once your changes are merged?
nothing