馃摑 Add JSDoc annotations for cached merge util function - #7331
Merged
sokra merged 2 commits intoMay 25, 2018
Merged
Conversation
|
|
Contributor
|
For maintainers only:
|
Contributor
Author
|
Hi, @sokra. i have seen you are author of @TheLarkInn any idea on this ? |
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we鈥檒l review the pull request soon. |
Member
|
@dev-drprasad This function performs an Object assign like merge, however it takes and caches the operation somewhat |
Contributor
Author
|
Hey @TheLarkInn ! i added annotations. can you please review ? i would like to create separate PRs for separate functions and classes if thats fine for you. |
sokra
approved these changes
May 25, 2018
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add JSDoc annotations for cachedMerge util function
What kind of change does this PR introduce?
Documention
Did you add tests for your changes?
N/A
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
N/A