Read 'browser' main field when target is 'electron-renderer' - #6814
Merged
Merged
Conversation
Contributor
|
@ooflorent was going to submit similar PR 😄 I guess the same check has to be added here as well, right? |
|
This could also use a test: https://github.com/webpack/webpack/tree/master/test/configCases/target |
ooflorent
force-pushed
the
fix/issue-6811
branch
from
March 21, 2018 09:35
877a686 to
e4808b2
Compare
Contributor
Author
|
Thanks for your feedback. I've also added an integration test. |
evenstensberg
approved these changes
Mar 21, 2018
evenstensberg
left a comment
Member
There was a problem hiding this comment.
Looks good, could discard the else and early return instead?
Contributor
Author
|
@ev1stensberg Regarding the early |
Member
|
@ooflorent no big deal, small picks 👍 |
sokra
approved these changes
Mar 21, 2018
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Member
|
Thanks |
|
this PR cause issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
If relevant, link to documentation update:
n/a
Summary
Fixes #6811
Does this PR introduce a breaking change?
no