Manually exclude internal tap of plugin. - #6415
Merged
Merged
Conversation
This was forcing the timestamp of the last trace to be the last event in the JSON trace, and thus breaking the CPU profile. Instead manually exclude this plugin from being traced to avoid this issue.
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Member
|
Thanks @samccone. 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 🐐 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was forcing the timestamp of the last trace to be the last event
in the JSON trace, and thus breaking the CPU profile.
Instead manually exclude this plugin from being traced to avoid this
issue.
--
reported here
https://twitter.com/probablyup/status/957436506263744513