Support resourceQuery in context dependencies. - #5732
Merged
Merged
Conversation
|
|
sokra
requested changes
Sep 30, 2017
| const dependencies = result.dependencies; | ||
|
|
||
| let loaders, resource, loadersPrefix = ""; | ||
| let loaders, resource, loadersPrefix = "", |
Member
There was a problem hiding this comment.
split this into multiple let declarations.
sokra
requested changes
Sep 30, 2017
sokra
left a comment
Member
There was a problem hiding this comment.
https://github.com/webpack/webpack/blob/master/lib/ContextReplacementPlugin.js#L100
This need to be changed too
Contributor
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Contributor
|
The minimum test ratio has been reached. Thanks! |
sokra
approved these changes
Oct 9, 2017
Author
|
@sokra Just wondering, when would this be merged into the next branch? It seems it needs a rebase, but would hold off if it'll just get out of date again |
Author
|
@sokra Ping? |
anuraaga
force-pushed
the
context-query
branch
from
November 15, 2017 07:59
b6c3426 to
28808ae
Compare
anuraaga
force-pushed
the
context-query
branch
2 times, most recently
from
November 15, 2017 16:03
be36a68 to
4d376cc
Compare
anuraaga
force-pushed
the
context-query
branch
from
November 16, 2017 06:13
4d376cc to
b86a9ad
Compare
anuraaga
force-pushed
the
context-query
branch
from
November 16, 2017 06:20
b86a9ad to
ce266cb
Compare
Author
|
@sokra I have gone ahead and rebased this PR - do you think it can be merged? It would be depressing for it to get out of sync with the branch again... |
sokra
approved these changes
Nov 16, 2017
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds support for resource queries in context dependencies.
Did you add tests for your changes?
Yes
If relevant, link to documentation update:
N/A
Summary
Some loaders require resource query for proper usage, and cannot be used at all with context dependencies.
Does this PR introduce a breaking change?
No, it only affects code that adds a resource query to a context, which currently does not work at all.
Other information
Fixes #5730