Cache bust source map fixup - #4972
Merged
Merged
Conversation
sokra
requested changes
Jun 1, 2017
| const sourceMapUrl = path.relative(path.dirname(file), sourceMapFile).replace(/\\/g, "/"); | ||
| let sourceMapUrl = path.relative(path.dirname(file), sourceMapFile).replace(/\\/g, "/"); | ||
| if(sourceMapFilename.indexOf("?[contenthash]") !== -1) { | ||
| sourceMapUrl += "?" + crypto.createHash("md5").update(source).digest("hex"); |
Member
There was a problem hiding this comment.
use replace(/\[contenthash\]/g, ...) instead.
| }); | ||
| const sourceMapUrl = path.relative(path.dirname(file), sourceMapFile).replace(/\\/g, "/"); | ||
| let sourceMapUrl = path.relative(path.dirname(file), sourceMapFile).replace(/\\/g, "/"); | ||
| if(sourceMapFilename.indexOf("?[contenthash]") !== -1) { |
Member
There was a problem hiding this comment.
if(sourceMapFilename.indexOf("[contenthash]") !== -1) {
rafde
force-pushed
the
cache-bust-source-map-fixup
branch
from
June 1, 2017 15:33
db0bdad to
f9d3cce
Compare
Contributor
Author
|
Outside topic, but your bot message
I recommend creating a team and have the bot notify the team about new changes. Example:
|
sokra
requested changes
Jun 2, 2017
| const sourceMapUrl = path.relative(path.dirname(file), sourceMapFile).replace(/\\/g, "/"); | ||
| let sourceMapUrl = path.relative(path.dirname(file), sourceMapFile).replace(/\\/g, "/"); | ||
| if(sourceMapUrl.indexOf("[contenthash]") !== -1) { | ||
| sourceMapUrl = sourceMapUrl.replace("[contenthash]", crypto.createHash("md5").update(source).digest("hex")); |
Member
There was a problem hiding this comment.
Use a regexp instead to replace every occurrence.
replace(/\[contenthash\]/g,
| "use strict"; | ||
|
|
||
| const path = require("path"); | ||
| var crypto = require("crypto"); |
rafde
force-pushed
the
cache-bust-source-map-fixup
branch
from
June 2, 2017 15:51
f9d3cce to
0611b63
Compare
rafde
force-pushed
the
cache-bust-source-map-fixup
branch
from
June 2, 2017 16:07
0611b63 to
afa7702
Compare
Contributor
…ul workaround for this bug in chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=508270
rafde
force-pushed
the
cache-bust-source-map-fixup
branch
from
June 2, 2017 17:06
afa7702 to
84b6554
Compare
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Contributor
Author
|
CI keeps failing. I don't know if I should be concerned about some of those failing. |
sokra
approved these changes
Jun 3, 2017
Member
only 1 of 3 CIs fail... that's ok... one of them is always broken, that's why we have 3 of them... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
Yes
If relevant, link to documentation update:
Replaces #4137
Summary
The PR is based on a useful feature introduced by the aforementioned PR, but that PR was not updated to address PR concerns. I am trying to finish the work started.
Does this PR introduce a breaking change?
No breaking changes. Only augmentation.
Tried to contact author of original PR but no response. I prefer to get this in sooner than later.