Test - improve EnvironmentPlugin code coverage - #4201
Merged
Merged
Conversation
added 2 commits
February 4, 2017 15:29
…pected errors to allow adding more tests easily
…th default values
|
|
11 tasks
Member
|
Nice and successful coverage increase |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Improve test coverage.
Did you add tests for your changes?
Yes
If relevant, link to documentation update:
#3716
Summary
Added tests for the
EnvironmentPluginto improve test coverage of this class to 100%.Improved how the regular expressions of the test's expected errors are defined. Before this change, every time a new environment variable or webpack configuration was added, several errors would need to be added. With this change it should be much easier and less error-prone to add more tests.
Does this PR introduce a breaking change?
No
Other information
My first PR 🎉 I'm happy to contribute with this awesome tool 😃