Drop ArrayMap for Map. - #3718
Merged
Merged
Conversation
Jessidhia
reviewed
Jan 4, 2017
| return this; | ||
| } | ||
|
|
||
| remove(key) { |
There was a problem hiding this comment.
Need to check if anything was calling .remove. The native Map prototype method is .delete.
Contributor
Author
There was a problem hiding this comment.
Nothing in this repo seems to use remove or clone.
Member
|
AppVeyor is currently down per https://twitter.com/appveyor/status/816518305770971137. Going to merge this. |
Member
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Drops the
ArrayMapclass for nativeMap.Did you add tests for your changes?
No.
If relevant, link to documentation update:
Summary
Drops the
ArrayMapclass for the nativeMap. Proposed to solve #3083.Does this PR introduce a breaking change?
The
clonemethod ofdependencyFactoriesanddependencyTemplatesno longer exists. It is not used by any of the plugins in this repo, but it may be used by plugins outside of this repo.Change
to
Other information