Update missing should type check calls - #3672
Merged
sokra merged 1 commit intoJan 2, 2017
Merged
Conversation
Jessidhia
reviewed
Jan 2, 2017
| // Arbitrary assertion; can't use .ok() as it could be 0, | ||
| // can't use typeof as that depends on webpack config. | ||
| require.resolve(`./sync/${name}Test`).should.not.be.undefined; | ||
| require.resolve(`./sync/${name}Test`).should.not.be.undefined(); |
There was a problem hiding this comment.
One thing I just noticed -- you can't access .should on undefined, it's TypeError!
You're supposed to use expect(value).to.not.be.undefined(), but the test runner doesn't expose expect
Contributor
Author
There was a problem hiding this comment.
@Kovensky null also - the should documentation uses should(null).not.be.ok(); (rather than expect), which is what I've used for the compareLocations tests for undefined in #3670
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Test bugfix
Did you add tests for your changes?
This PR is only tests
If relevant, link to documentation update:
N/A
Summary
shouldtype checks need to be called to error if the type check fails. Without calling, the test essentially has an empty body and will pass regardless.Change made using find/replace in sublime
(\.be\.[^(;]+);\1();Does this PR introduce a breaking change?
No
Other information
None