feat(performancebudgets): set warnings in console off by default - #3604

the feedback that we have gotten is that for this to be a opt-out, it needs to have more intelligent env understandings, as well as calculating gzip and minified sizes during dev env vs prod.

Reviewing the feedback, I understand and support this decision. Let's start thinking about how we might go about detecting environments better so there's a real chance this can be switched back on as a default for folks - @TheLarkInn is there an issue already open for discussing ideas?

Not yet, let's get one on the docket and I'll.drop it into our feature milestone

Glad to see this was turned off.

With an empty bundle & webpack-dev-server -d, --inline being enabled by default caused false positives that my team didn't know how to resolve. (Similarly, using html-webpack-plugin shows lodash being included in the bundle at ~350k, but I suspect it's another false positive).

So, I think we'd need to account for a few things:

• How can we restrict the calculation to dependencies from the primary entry-point (not webpack/hot/client, react-hot-loader/patch, etc.)?
• Is costly gzip'ing a requirement, or is there a median cost saving (e.g. 60%) that we can apply to save spinning cycles as part of a performance check?
• We run some crazy clojure compiler stuff against our code (I didn't set it up, I swear!), so a sane default could be enabling performance based on NODE_ENV=production.