fix issue #3252 - #3259
Merged
Merged
fix issue #3252#3259
Conversation
Contributor
Author
|
Test passed on |
sokra
requested changes
Nov 9, 2016
| @@ -0,0 +1,7 @@ | |||
| module.exports = function supportDefaultAssignment() { | |||
| try { | |||
| return true; | |||
Contributor
Author
There was a problem hiding this comment.
I just want it to be filtered. Because it fails when use uglifyjs plugin.
Member
There was a problem hiding this comment.
| break; | ||
| default: | ||
| this.enterPattern(property.value, onIdent); | ||
| } |
Member
There was a problem hiding this comment.
Could you remove the whole switch-case and shorten this to this.enterPattern(property.value, onIdent)?
From AST explorer it looks like property.type is always Property.
Contributor
Author
There was a problem hiding this comment.
Sure, I will make the change.
sokra
approved these changes
Nov 9, 2016
Member
|
Thanks |
Contributor
Author
|
My pleasure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Default argument assignment is missing. Ref #3252
What is the new behavior?
Default argument assignment will be correctly placed.
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Other information: