Skip to content

Bump required node version to 0.12, the last supported LTS - #3181

Merged
sokra merged 1 commit into
webpack:masterfrom
SpaceK33z:bump-node-version
Oct 26, 2016
Merged

sokra merged 1 commit into
webpack:masterfrom
SpaceK33z:bump-node-version

Conversation

@SpaceK33z

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Node.js >=0.6 is supported according to the package.json.

What is the new behavior?

Node.js >= 0.12 is supported. On Slack it was discussed that we should only support active LTS releases.

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact: If the user is running a Node.js version older then 0.12, webpack can break.
  • Migration path for existing applications: Update Node.js to at least 0.12
  • Github Issue(s) this is regarding:

Other information:

//cc @NekR @danez

@NekR

NekR commented Oct 24, 2016

Copy link
Copy Markdown

Does it make sense to support 0.12 and not test builds on it in CI? I would say it does because maintenance of 0.12 end in Dec anyway.

@danez

danez commented Oct 24, 2016

Copy link
Copy Markdown
Contributor

Although this way we don't really know if it works on node 0.12 right now, by looking at travis.

@sokra

sokra commented Oct 26, 2016

Copy link
Copy Markdown
Member

We'll readd CI testing on 0.12.

@sokra
sokra merged commit d745146 into webpack:master Oct 26, 2016
@SpaceK33z
SpaceK33z deleted the bump-node-version branch October 26, 2016 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants