Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
Allows vectorizer-first syntax like Vectorizer.text2vecWeaviate('custom', t2v -> t2v.dimensions(1)).
bevzzz
force-pushed
the
v6-vectorizer-first
branch
from
June 17, 2025 07:52
84d9dea to
615145e
Compare
This is getting awfully hacky, because now we're pretenting do builder Vectorizer while actually builder a VectorIndex object.
Vectorizer.<Hnsw, Hnsw.Builder>text2vecContextionary(
Hnsw::of,
t2v -> t2v.vectorizeCollectionName(false),
hnsw -> hnsw.cleanupIntervalSeconds(300));
Collaborator
Author
|
Here's another thing I had in mind while working on it: // Using default vector index
Vectorizer.text2VecContextionary(t2v -> t2v.vectorizeCollectionName(false));
// Adding explicit vector index configuration
Vectorizer.<Hnsw.Builder, Hnsw>text2VecContextionary(
t2v -> t2v.vectorizeCollectionName(false),
Hnsw::of, hnsw -> hnsw.cleanupIntervalSeconds(30));
// Adding explicit vector index configuration (current syntax)
Hnsw.of(
Text2VecContextionaryVectorizer.of(t2v -> t2v.vectorizeCollectionName(false)),
hnsw -> hnsw.cleanupIntervalSeconds(30)); |
Collaborator
Author
|
Superseded by #406 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows vectorizer-first syntax like:
This PR is more of a POC I put together quickly, as underneath the library still has the "hierarchy"
VectorIndex --has-> Vectorizerand not the other way around.I haven't found a good way to add
.vectorIndexto all vectorizer builders without rewriting that hierarchy.