Skip to content

H2 web console fail to start because password not encoded #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thibaultmeyer merged 1 commit into from
Oct 9, 2023
Merged

H2 web console fail to start because password not encoded #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion voidframework-h2/src/main/java/dev/voidframework/h2/H2WebConsole.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import dev.voidframework.core.lifecycle.LifeCycleStop;
import jakarta.inject.Inject;
import jakarta.inject.Singleton;
import org.h2.server.web.WebServer;
import org.h2.tools.Server;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down Expand Up @@ -50,7 +51,8 @@ public void start() throws SQLException {

if (this.configuration.hasPath("voidframework.h2.webAdminPassword")) {
argumentList.add("-webAdminPassword");
argumentList.add(this.configuration.getString("voidframework.h2.webAdminPassword"));
argumentList.add(
WebServer.encodeAdminPassword(this.configuration.getString("voidframework.h2.webAdminPassword")));
}

if (this.configuration.getBoolean("voidframework.h2.webAllowOthers")) {
Expand Down
2 changes: 1 addition & 1 deletion voidframework-h2/src/main/resources/reference.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ voidframework {
webPort = 9002

# Defines the password to access preferences and tools of H2 Console
webAdminPassword = "sa"
webAdminPassword = null

# Specifies if other computers are allowed to connect
webAllowOthers = false
Expand Down