Conversation
ahesford
requested changes
Sep 19, 2026
| exec 2>&1 | ||
| [ -r conf ] && . ./conf | ||
| exec dhcpcd -B eth0 $OPTS 1>&2 | ||
| exec dhcpcd -q -B eth0 $OPTS 1>&2 |
Member
There was a problem hiding this comment.
Suggested change
| exec dhcpcd -q -B eth0 $OPTS 1>&2 | |
| exec dhcpcd -B eth0 ${OPTS:--q} 1>&2 |
If this is to be applied, it needs to be a default fallback for $OPTS, not forced into everybody's invocation with no means to override.
| exec 2>&1 | ||
| [ -r conf ] && . ./conf | ||
| exec dhcpcd -B ${OPTS:=-M} 1>&2 | ||
| exec dhcpcd -q -B ${OPTS:=-M} 1>&2 |
Member
There was a problem hiding this comment.
Suggested change
| exec dhcpcd -q -B ${OPTS:=-M} 1>&2 | |
| exec dhcpcd -B ${OPTS:--M -q} 1>&2 |
As in the other case, this needs to be an overridable default, not a hard imposition.
This also swaps the substitution to remove an assignment to OPTS, which is superfluous here.
mxlgv
force-pushed
the
min-dhcpcd-log-dup
branch
from
September 21, 2026 05:55
43e0346 to
bd9e1c0
Compare
Contributor
Author
|
@ahesford Thanks for the help! I made the corrections according to your instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Note
This relates to an issue that could not be resolved simply by disabling the logging service.
Therefore, the final solution is to keep the logging service enabled to capture critical errors and any errors that might occur before
dhcpcd's own logging initializes.Thanks to the
-qoption, we will no longer receive duplicate normal messages, though critical will still be duplicated.