Skip to content

od: use standard single quotes for invalid option argument diagnostics - #14759

Open
krosci wants to merge 1 commit into
uutils:mainfrom
krosci:fix/od-error-quoting
Open

krosci wants to merge 1 commit into
uutils:mainfrom
krosci:fix/od-error-quoting

Conversation

@krosci

@krosci krosci commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

This change addresses the od.pl failures tracked in #14705 by using standard single quotes instead of bash-style ansi quoting in option argument diagnostics. Arguments containing control characters such as tabs are now displayed directly enclosed in single quotes matching GNU coreutils. Regression tests have been added to verify diagnostic output for options with control characters.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/csplit/csplit is no longer failing!
Congrats! The gnu test tests/du/max-depth is no longer failing!
Congrats! The gnu test tests/fold/fold is no longer failing!
Congrats! The gnu test tests/misc/just-created is no longer failing!
Congrats! The gnu test tests/ptx/word-regex-loop is no longer failing!

@krosci
krosci force-pushed the fix/od-error-quoting branch 2 times, most recently from 6c0a377 to dc987b3 Compare September 21, 2026 13:18
@krosci
krosci force-pushed the fix/od-error-quoting branch from dc987b3 to fc7d139 Compare September 21, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant