fix(autodiscovery/helmfile): use relative file path in generated manifests - #10109
Merged
olblak merged 4 commits intoAug 26, 2026
Merged
Conversation
…fests The File field in the generated condition and target was set to foundHelmfile (absolute path within the SCM clone) instead of relativeFoundChartFile. This caused every helmfile-derived pipeline to fail at the condition step with: init yaml files: absolute path "..." is not allowed: files must stay within the working directory "..." As a result the target was always skipped, silently preventing any helmfile release from being updated. ManifestName and ConditionName already used relativeFoundChartFile correctly — File was the only field that did not. Fixes updatecli#10108 Related to updatecli#9759, which fixed the identical pattern in the updatecli autodiscovery plugin.
Member
|
Thanks for the fix |
olblak
enabled auto-merge (squash)
August 25, 2026 19:08
Member
|
@alecharp Could you fix the broken unit test :) |
…path fix Update test expectations to match the new behavior introduced in aaba087: file paths in generated manifests are now relative to rootDir, not to the test's working directory.
auto-merge was automatically disabled
August 26, 2026 07:49
Head branch was pushed to by a user without write access
olblak
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10108.
The
Filefield in the generated condition and target was set tofoundHelmfile(absolute path within the SCM clone) instead ofrelativeFoundChartFile. This caused every helmfile-derived pipeline to fail at the condition step when anscmidis configured.ManifestNameandConditionNamealready usedrelativeFoundChartFilecorrectly —Filewas the only field that did not.This is the same bug fixed for the
updatecliautodiscovery plugin in #9759; the helmfile plugin was not updated at the same time.Before
All helmfile-derived condition steps fail with:
The target is skipped due to
dependsOn conditions, silently preventing any helmfile release from being updated.After
Conditions resolve correctly against the SCM clone and targets apply as expected:
Tested locally by building from this branch and running
updatecli pipeline applyagainst a real helmfile repository — 6 version-bump PRs were opened correctly where previously 0 were.Checklist