feat!: add Iconify FileSystemHMRIconLoader support - #440
Merged
Merged
Conversation
|
|
commit: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
FileSystemHMRIconLoader support
userquin
marked this pull request as draft
September 6, 2026 15:36
Member
Author
|
Updating iconify utils, hmr-utils subpackage export updated... |
userquin
marked this pull request as ready for review
September 6, 2026 16:04
antfu
approved these changes
Sep 7, 2026
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes:
unpluginto3.3.0(breaking => node 20 or above)@iconify/utilsto3.1.6: added the newFileSystemHMRIconLoader(requires custom implementation since the new=> fixed athmr-utilssubpackage export cannot be directly consumed here3.1.7)custom logic to deal with HMR (core/hmr.tsmodule): some changes at core loader and index.ts to handle HMR correctlyLinked Issues
closes #424
supersedes #425
supersedes #439
Additional context
This pull request includes changes for the first, fourth, and fifth entries in this comment's list: #439 (comment)