Only show the demo button's running state on slow runs - #499
Merged
Merged
Conversation
Warm runs of the confetti demo finish in a few milliseconds, so the Running label and disabled styling flashed on every click. The running state now appears only when a run exceeds 250ms, the dimmed styling follows that same delayed flag instead of the disabled attribute, and the wider label's width is reserved so the swap never resizes the button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The homepage confetti demo's button flashed its Running… label on every click because warm runs complete in a few milliseconds. Standard delayed-indicator fix: the running state (label + dimming) only appears when a run exceeds 250ms, and the button reserves the wider label's width so the swap never changes its size. Fast clicks now change nothing visually; cold first clicks still show feedback.