Make the homepage confetti example a live demo - #498
Merged
Merged
Conversation
Adds a Run this example button under the Inline Scripts confetti snippet that recreates the example's inline text/ts script tag and executes it through the real /run helper — transform via esm.unpkg.com/transform, canvas-confetti loaded from the ESM CDN — so the docs demonstrate themselves and the button doubles as a production canary for the whole inline-script pipeline. The browser smoke suite gains a case that clicks the button on the served homepage and waits for the confetti canvas; CI's smoke step now also runs the www assets dev server, which the dev worker needs for hydration.
Miniflare cache and trace state from a local wrangler dev session was accidentally committed; remove it from tracking and ignore .wrangler everywhere (only unpkg-www had the ignore rule).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Inline Scripts section's confetti example gains a Run this example button that executes the exact snippet through the real
/runpipeline: it recreates the inlinetext/tsscript tag, loads/run, which transforms the source via esm.unpkg.com/transform and imports canvas-confetti from the ESM CDN. The docs now demonstrate themselves, and the button doubles as a permanent production canary for the whole inline-script path.RunDemohydrated component; registered in the assets bundle.wrangler devsession) and ignores.wrangler/repo-wide — previously only unpkg-www had the ignore rule.