Fix fly Docker build for injected workspace packages - #497
Merged
Merged
Conversation
inject-workspace-packages requires every workspace manifest to be present for the lockfile's injected file: entries to install, and syncInjectedDepsAfterScripts needs the injected copies to exist when build output syncs. The image only copied two manifests, so every fly deploy since injection was enabled failed during pnpm run build. Copy all workspace manifests, match the packageManager pnpm version, and scope the build to the packages the image ships.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every fly deploy has failed since inject-workspace-packages was enabled (f0354be): the Docker build only copied the unpkg-files and unpkg-worker manifests, so the lockfile's injected file: entries could not install and the post-build injected-deps sync hit ENOENT. This copies all workspace manifests, bumps the image's pnpm to match packageManager (10.15.0), and scopes the image build to unpkg-worker + unpkg-files. Verified by a successful staging deploy of unpkg-files with this Dockerfile.