Skip to content

cmds/core/poweroff: commit filesystem caches to disk before poweroff - #3752

Merged
MDr164 merged 2 commits into
u-root:mainfrom
binjip978:poweroff-sync
Sep 20, 2026
Merged

MDr164 merged 2 commits into
u-root:mainfrom
binjip978:poweroff-sync

Conversation

@binjip978

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.39%. Comparing base (fa6b075) to head (b80f065).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3752   +/-   ##
=======================================
  Coverage   61.39%   61.39%           
=======================================
  Files         648      648           
  Lines       45670    45674    +4     
=======================================
+ Hits        28037    28042    +5     
+ Misses      17633    17632    -1     
Flag Coverage Δ
.-amd64 90.90% <ø> (ø)
cmds/...-amd64 52.48% <0.00%> (-0.02%) ⬇️
integration/generic-tests/...-amd64 29.32% <ø> (ø)
integration/generic-tests/...-arm 31.70% <ø> (ø)
integration/generic-tests/...-arm64 28.05% <ø> (-0.07%) ⬇️
integration/gotests/...-amd64 60.34% <ø> (+<0.01%) ⬆️
integration/gotests/...-arm 60.59% <ø> (ø)
integration/gotests/...-arm64 60.78% <ø> (ø)
pkg/...-amd64 59.16% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
everything 66.34% <0.00%> (+<0.01%) ⬆️
cmds/exp 34.30% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Sep 14, 2026
Comment thread cmds/core/poweroff/poweroff_linux.go Outdated
@binjip978
binjip978 force-pushed the poweroff-sync branch 2 times, most recently from 23a38f0 to 1ae66df Compare September 15, 2026 16:34
rminnich
rminnich previously approved these changes Sep 16, 2026
@rminnich rminnich added automerge Applying this label auto-merges the PR when ready Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels Sep 16, 2026
Comment thread cmds/core/poweroff/poweroff_linux.go Outdated
rminnich
rminnich previously approved these changes Sep 20, 2026
@MDr164

MDr164 commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Linter still complains, otherwise fine to merge

add -n flag to avoid sync

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@MDr164
MDr164 enabled auto-merge (rebase) September 20, 2026 16:19
@MDr164
MDr164 merged commit 3401bc3 into u-root:main Sep 20, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Applying this label auto-merges the PR when ready Awaiting author Waiting for new changes or feedback for author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants